diff --git a/uapbd/src/public/nccloud/api/uapbd/msg/MsgResource.java b/uapbd/src/public/nccloud/api/uapbd/msg/MsgResource.java index 21c1c93..45c780d 100644 --- a/uapbd/src/public/nccloud/api/uapbd/msg/MsgResource.java +++ b/uapbd/src/public/nccloud/api/uapbd/msg/MsgResource.java @@ -32,12 +32,13 @@ import java.util.Date; */ @Path("uapbd/msg") public class MsgResource extends AbstractNCCRestResource { + private static final String DEFAULT_SENDER = "NC_USER0000000000000"; public String getModule() { return "uapbd"; } - private HYSuperDMO superDMO = null; + private HYSuperDMO superDMO; public HYSuperDMO getSuperDMO() { @@ -65,7 +66,7 @@ public class MsgResource extends AbstractNCCRestResource { // 根据传递的角色查询要发送消息的用户信息 UserVO[] userVOS = getUserByRole(roleId); - if (userVOS == null) { + if (userVOS == null || userVOS.length == 0) { return ResultMessageUtil.toJSON(false, "未查询到用户"); } @@ -87,7 +88,7 @@ public class MsgResource extends AbstractNCCRestResource { CommonMessageVO commonMessageVO = new CommonMessageVO(); commonMessageVO.setReceiver(users); commonMessageVO.setTitle("BOM变更信息通知"); - commonMessageVO.setSender("NC_USER0000000000000"); + commonMessageVO.setSender(DEFAULT_SENDER); commonMessageVO.setSendDataTime(new UFDateTime()); commonMessageVO.setPriority(1); commonMessageVO.setMessageContent(content); @@ -95,8 +96,8 @@ public class MsgResource extends AbstractNCCRestResource { PfMessageUtil.sendNoticeMessage(commonMessageVO); return ResultMessageUtil.toJSON(true, "消息发送成功"); - } catch (BusinessException e) { - Logger.error("MsgResource-exp:" + e.getMessage()); + } catch (Exception e) { + Logger.error("MsgResource-exp:", e); return ResultMessageUtil.exceptionToJSON(new BusinessException(e.getMessage(), e)); } }