From e15ef4f523589eade9bd5d70f96ec4ac618d5190 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=BC=A0=E6=98=8E?= <125556714+Topfunplus@users.noreply.github.com> Date: Tue, 3 Jun 2025 18:49:31 +0800 Subject: [PATCH] =?UTF-8?q?=E4=BF=AE=E5=A4=8D=E8=AF=B7=E8=B4=AD=E5=8D=95?= =?UTF-8?q?=E8=BD=AC=E6=8D=A2=E5=88=B0=E9=87=87=E8=B4=AD=E8=AE=A2=E5=8D=95?= =?UTF-8?q?=E6=97=B6=E7=9A=84=E5=BC=82=E5=B8=B8=E5=A4=84=E7=90=86?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - 移除了不必要的异常处理工具类 ExceptionUtils -优化了查询 SQL 的构建逻辑- 增加了对 pkGroup 和 pkorgs 的空值校验,抛出 BusinessException - 删除了冗余的注释和代码 --- .../plugin/BatchTransferToPurchaseOrder.java | 23 ++++++++----------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/pu/src/private/nc/bs/pu/m21/plugin/BatchTransferToPurchaseOrder.java b/pu/src/private/nc/bs/pu/m21/plugin/BatchTransferToPurchaseOrder.java index df5ad4c..0a28980 100644 --- a/pu/src/private/nc/bs/pu/m21/plugin/BatchTransferToPurchaseOrder.java +++ b/pu/src/private/nc/bs/pu/m21/plugin/BatchTransferToPurchaseOrder.java @@ -22,10 +22,7 @@ import nc.vo.pu.m21.entity.OrderHeaderVO; import nc.vo.pu.m21.entity.OrderItemVO; import nc.vo.pu.m21.entity.OrderVO; import nc.vo.pub.BusinessException; -import nc.vo.pub.CircularlyAccessibleValueObject; -import nc.vo.pub.ISuperVO; import nc.vo.pub.VOStatus; -import nc.vo.pubapp.pattern.exception.ExceptionUtils; import nc.vo.pubapp.pattern.model.entity.bill.AbstractBill; import nc.vo.scmpub.res.billtype.POBillType; import nc.vo.scmpub.util.AppInfoContext; @@ -89,8 +86,6 @@ public class BatchTransferToPurchaseOrder implements IBackgroundWorkPlugin { return resultList.toArray(new PraybillVO[resultList.size()]); } catch (Exception e) { logger.error("ѯ빺ʧ", e, this.getClass(), "getQualifiedPurchaseRequests"); - // marsh ׳쳣 - ExceptionUtils.marsh(e); return new PraybillVO[0]; } } @@ -98,20 +93,22 @@ public class BatchTransferToPurchaseOrder implements IBackgroundWorkPlugin { /** * ѯSQL ѯͼ */ - private String getSql(BgWorkingContext bgwc) { + private String getSql(BgWorkingContext bgwc) throws BusinessException { logger.debug("ʼѯSQL", this.getClass(), "getSql"); String[] pkorgs = bgwc.getPk_orgs(); String pkGroup = AppBsContext.getInstance().getPkGroup(); + if (pkGroup == null) { + throw new BusinessException("빺תɹʱpkGroupΪ"); + } + if (MMArrayUtil.isNotEmpty(pkorgs)) { + throw new BusinessException("빺תɹʱ֯Ϊ"); + } MMSqlBuilder sb = new MMSqlBuilder(); sb.append(" SELECT PK_PRAYBILL_B"); sb.append(" FROM TRANS_PRAYBILL_PURCHASE"); - if (pkGroup != null) { - sb.append(" WHERE PK_GROUP ", pkGroup); - } - if (MMArrayUtil.isNotEmpty(pkorgs)) { - sb.append(" AND"); - sb.append(" PK_ORG", pkorgs); - } + sb.append(" WHERE PK_GROUP ", pkGroup); + sb.append(" AND"); + sb.append(" PK_ORG", pkorgs); String finalSql = sb.toString(); logger.debug("SQL", this.getClass(), "getSql"); return finalSql;